Randomize Root Password #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
|
There are still open questions: |
Member
|
Documentation missing. |
ewoutp
suggested changes
Jan 14, 2019
Contributor
ewoutp
left a comment
ewoutp
left a comment
There was a problem hiding this comment.
I don't like the breaking change.
Let's change that.
Other than that comments are missing, some naming issues and lack of documentation.
ewoutp
reviewed
Jan 15, 2019
Contributor
ewoutp
left a comment
ewoutp
left a comment
There was a problem hiding this comment.
- Couple of minor issues.
- K8s resource naming issue is worrying. At least fix that.
After that LGTM
ewoutp
reviewed
Jan 16, 2019
ewoutp
reviewed
Jan 16, 2019
ewoutp
reviewed
Jan 16, 2019
ewoutp
reviewed
Jan 16, 2019
ewoutp
reviewed
Mar 19, 2019
Contributor
ewoutp
left a comment
ewoutp
left a comment
There was a problem hiding this comment.
Couple of issues, then LGTM
added 4 commits
March 19, 2019 09:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomize root password or use provided secret.
This is a breaking change.